Repository navigation
chore(canary): retire the two Bun CSS minifier watches - #1506
Merged
Merged
Conversation
css-minifier-knows-the-seven-pseudo-elements watched oven-sh/bun#41120, closed 2026-10-19 after #41122 cleared four of the seven. The three left are the ::scroll-marker family, which lightningcss 1.33.0 also warns on (parcel-bundler/lightningcss#1321, open). css-minifier-lowercases-target-current watched oven-sh/bun#42480. Its fix #42484 closed unmerged on 2026-10-27, when #47025 consolidated the CSS parser PRs and left #41139 out. Both re-read false on 1.4.4-canary.1+5c6d4e2. The site builds CSS with Lightning CSS directly, so neither stood for a need here. The writer exemption for upstream-watches.ts goes with them, since those two probes were its only Bun.write calls.
Contributor
Wire-size diff vs merge base
Brotli q11, the quality the edge serves. Every number here is deterministic: Client assetsNo change. 39 files, 231.31 KiB Brotli total. PagesNo change. 77 files, 702.62 KiB Brotli total. Worker bundleNo change. 293.77 KiB gzip. Dictionary transportFamily dictionary acquisition: no change, 14.50 KiB q11.
|
oddharsh
added a commit
that referenced
this pull request
Nov 1, 2026
… and plant the verdict watches' control #1506 retired the two Bun CSS watches and deleted upstream-watches.ts's writer exemption with them. The merge kept this branch's wording, which still named those watches. The verdict watches are the file's only writers now (Bun.write in the HTML probe, writeFileSync in three others), so the exemption stays and says so. With #1487 on main, the control owed since this PR opened goes in: verdict-watch-forgets-its-memory-file drops the memory file from `landed` and expects the contract test to say a moved row's issue no longer names bun-minifier-not-a-swap.md. CAUGHT in 0.5s.
This was referenced Nov 1, 2026
oddharsh
added a commit
that referenced
this pull request
Nov 2, 2026
#1494) * feat(watches): read the premises of four declined verdicts every night A "measured, not worth it" verdict is true on the day it's written, and nothing reopens it when bun moves. VERDICT_WATCHES in tools/lib/upstream-watches.ts points the upstream-watch probe at this repo's own declines: each entry probes the premise a decline rests on, reads false while it holds, and names the memory file that records it. Four premises, all moving with bun, so the canary sees a flip first: - bun's JS minifier trails oxc on the frozen parity fixtures (+84 B) - bun's CSS ignores browser targets on luna.css (+2697 B brotli, bun#40368) - bun's HTML "minify" keeps every comment and grows the page - bun check's esnext lib lacks Math.sumPrecise, Iterator.concat, JSON.rawJSON canary-bun.ts runs them beside BUN_WATCHES. The memory file rides in each row's `landed`, so a moved row's issue line says which verdict to re-measure; a contract test renders a moved row and asserts it does. * fix(watches): drop the retired CSS watches from the writer exemption, and plant the verdict watches' control #1506 retired the two Bun CSS watches and deleted upstream-watches.ts's writer exemption with them. The merge kept this branch's wording, which still named those watches. The verdict watches are the file's only writers now (Bun.write in the HTML probe, writeFileSync in three others), so the exemption stays and says so. With #1487 on main, the control owed since this PR opened goes in: verdict-watch-forgets-its-memory-file drops the memory file from `landed` and expects the contract test to say a moved row's issue no longer names bun-minifier-not-a-swap.md. CAUGHT in 0.5s. --------- Co-authored-by: Aadharsh Pannirselvam <19518661+oddharsh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires two watches in
tools/lib/upstream-watches.tsthat can't land through the threads they name. Each entry becomes a datedRETIREDnote, the same way #1293 did it.css-minifier-knows-the-seven-pseudo-elements: css: the pseudo-element table trails lightningcss, so::details-content,::picker(),::checkmarkand the carousel selectors warn as invalid oven-sh/bun#41120 was closed on 2026-10-19 after #41122 cleared four of the seven. The three warnings left are::scroll-marker,::scroll-marker-groupand::scroll-button(). lightningcss 1.33.0 warns on the same three (Add ::scroll-marker, ::scroll-marker-group and ::scroll-button() parcel-bundler/lightningcss#1321, open), so the fix belongs upstream of Bun's port.css-minifier-lowercases-target-current: css::target-current,:target-beforeand:target-afterare unknown to the pseudo-class table, so they are emitted verbatim and never merge oven-sh/bun#42480 is still open, but its fix #42484 closed unmerged on 2026-10-27. That's when css: consolidate the open CSS parser fixes oven-sh/bun#47025 consolidated the CSS parser PRs and listed #41139 among fixes for input nobody writes.I re-read both on
1.4.4-canary.1+5c6d4e2: 3 warnings, and:TARGET-CURRENTis still emitted verbatim. The site builds CSS with Lightning CSS (tools/build.ts:42), never withBun.build, so neither watch stood for a need here.Two more changes follow from the retirement:
docs/MAINTENANCE.md.config/derivations.jsondrops the writer exemption forupstream-watches.ts. Those two probes were its onlyBun.writecalls, and the census test fails on a stale exemption.Checks:
check:fastis green (1624 pass, 0 fail) andderive:checkis clean. 6 Bun watches remain, above the contract test's floor of 5.Not done here: oven-sh/bun#42480 is still open upstream. Closing it is the owner's call.